-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0068 | Bump version for RFT #523
Conversation
Clarify the use of version, introduce changelog. Fixes #520.
903f25e
to
d3cdfe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks complete & effective to me ⭐ #520 (comment)
I don't quite understand why the version of an independent sub standard needs to be bumped just because a new asset name label is used? They all have nothing to do with each other. |
@alessandrokonrad you have to put an implementor hat on, like 5Binaries or Smaug or any wallet provider actually that seek to support the CIP. If the CIP keeps changing and new formats / asset classes are added, we end up in a similar situation to CIP-0030 where everyone is implementing it but no one is actually implementing the same thing. Then, from a user perspective, it's hard to know what version of the CIP is actually supported. Thus, we need to have an overarching version number that is incremented when significant changes are made. Introduce a new asset class falls in this category. And indeed, modifying the format of a single one should also lead to a version increase. These can't be decoupled in practice because they're part of the same CIP. So they will always be considered as a bundle. |
Yes I get this and it makes sense, however this is not the intention of the version field in the datum. CIP-0068 is the base structure and all those sub standards utilize it. They really can be seen as their own independent standards. We could seperate them and have them as their own CIPs, but I feel like this is overkill for some token standards based on CIP-0068. |
yes that's great @Crypto2099 - I knew this material had several upcoming concurrent changes and really wanted to incorporate the above into the baseline back in June, especially since the versioning question already appeared settled by @Ryun1's additions to CIP-0001. Some of the items in the OP I think are done already & we can confirm whatever remains... I've added it to next week's agenda. I also think there could be a case for a CIP specification for Beacon Tokens so I would also like to get the CIP-0068 platform fully straightened out before I make that pitch to the developer 🧐 p.s. I've put it in the agenda sequence after CIP-0072 which I think is a "quickie" (maybe even a last-check) but before "Domain Name Resolution" which is a long-term, open-ended, non-urgent problem. |
@Crypto2099 I'm closing this |
Active
Fixes #520.
cc @rphair @Ryun1 @alessandrokonrad @AndrewWestberg @mmahut @SmaugPool