Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0030 | A few small fixes #570

Merged
merged 10 commits into from
Aug 15, 2023
Merged

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Jul 31, 2023

See these few small formatting fixes.

Changes:

  1. Changed old style links that pointed to CIP-0005.md, these would require a short redirect because of past change to CIP markdown file naming.
  2. Added javascript language indicators for code snippet data types and error codes.
  3. Added missing APIError for api.getExtensions().
  4. Fixed incorrect reference to cardano.{walletName}.extensions which was removed during development of CIP-0030 | Upgrade to latest format & propose version / extension scheme #446. Replaced with correct reference to api.getExtensions().
  5. Fixed highlighting for references to APIError, to all be APIError and not APIError.
  6. A couple small spelling fixes.

Motivation:

  1. Just more convenient to follow direct links.
  2. Will rendered the snippets with syntax highlighting which improves readability.
  3. This seems like an oversight and not intentional design.

@Ryun1 Ryun1 added Correction Fixing minor issue or typo Category: Wallets Proposals belonging to the 'Wallets' category. labels Aug 1, 2023
@rphair rphair changed the title CIP-30 Fixes | A few small fixes CIP-0030 | A few small fixes Aug 1, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me & it's especially helpful to have that update from the extensions field to method: that could cause some real problems for new arrivals to the standard (we tend to miss things like that when we've been working with something for a while).

Also tagging a few more contributors to the CIP in case they might add anything else (apologies if I've missed anyone): @rooooooooob @alessandrokonrad @refi93 @vsubhuman

@Crypto2099
Copy link
Collaborator

Simple, mostly cosmetic and housekeeping changes, see no reason not to merge as-is.

CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
CIP-0030/README.md Outdated Show resolved Hide resolved
Ryun1 and others added 9 commits August 15, 2023 17:43
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@Ryun1 Ryun1 merged commit 27a1f8d into cardano-foundation:master Aug 15, 2023
Ryun1 added a commit to Ryun1/CIPs that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Wallets Proposals belonging to the 'Wallets' category. Correction Fixing minor issue or typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants