-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0030 | A few small fixes #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me & it's especially helpful to have that update from the extensions
field to method: that could cause some real problems for new arrivals to the standard (we tend to miss things like that when we've been working with something for a while).
Also tagging a few more contributors to the CIP in case they might add anything else (apologies if I've missed anyone): @rooooooooob @alessandrokonrad @refi93 @vsubhuman
15cdafc
to
9f01c57
Compare
Simple, mostly cosmetic and housekeeping changes, see no reason not to merge as-is. |
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
See these few small formatting fixes.
Changes:
CIP-0005.md
, these would require a short redirect because of past change to CIP markdown file naming.APIError
forapi.getExtensions()
.cardano.{walletName}.extensions
which was removed during development of CIP-0030 | Upgrade to latest format & propose version / extension scheme #446. Replaced with correct reference toapi.getExtensions()
.APIError
, to all beAPIError
and not APIError.Motivation: