-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multi assets #380
Feature/multi assets #380
Conversation
when a transaction output has one or more tokens, a list is displayed under the value on ada Ref: EX-1124
this add a list of minted and burned tokens on the detail of a transaction. if it doesn't has any, the respective fields won't be displayed Ref: EX-1124
this add the token fields to the gql query and modify the transaction details transformer. the component to display this has been modified on the 9f99e17 commit Ref: EX-1124
this add a list of tokens with the balances of each one for an address details Ref: EX-1123 feat: add filter for defined values on assetBalances array Ref: EX-1123 feat: add multiassets stories for transaction info and address summary Ref: EX-1123 EX-1124 feat: add policy id to address token balance this adds the policy id to gql query and adds a tooltip component to display it as a description, this tooltip is being used on each asset Ref: EX-1123 feat: add policy id for transaction assets this adds the policy id on minted, burned, inputs and outputs tokens Ref: EX-1124
feat: add message if address has not tokens Ref: EX-1123
when the token list is greater than 5 the scrollbar is display Ref: EX-1123 EX-1124
Ref: EX-1124 EX-1123
21568f6
to
f9e5b51
Compare
Refs #1148
is |
I think so, maybe @rhyslbw can clarify? |
Yes, we use yarn offline package cache to facilitate reproducible builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. We just need DE and JA translations for the following phrases:
- Ada Balance
- Tokens balance
- Policy ID
- This address has no tokens
- Minted tokens
- Burned tokens
I'll sort this out.
Here are the Japanese translations: Ada Balance ADA残高 |
In the latest version of cardano-graphql, ada no longer is represented as a token
12db667
to
a4151fe
Compare
a4151fe
to
c409b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good accept for one minor issue. The "Tokens balance" is not horizontally aligned with an addresses tokens, as seen here https://explorer.mary-qa.dev.cardano.org/en/address.html?address=addr_test1qz3gkzmatgtvw7zdkttvchftja4fys79krn7rue6x7dc43t939ww4vt849h8wpjv38czxt4q97vc8438tte28amvwm3qm63e2w. I played with the element and found changing the margin-top
from 5px
to 0px
on the TransactionTokenList_token
fixed this.
Hey @rhyslbw I have pushed the DE translations … not sure if it's relevant but I saw this error when running |
Thanks @DominikGuzei |
30f1618
to
73c4fc0
Compare
This PR adds support for multiassets on the transaction and address pages
the assets are displayed on the following fields:
each field has:
For this implementation the multi assets branch on the cardano graphql was usedhttps://github.com/input-output-hk/cardano-graphql/tree/feature/multi-asset
The@cardano-graphql/client-ts
dependency version should be updated once the nextcardano-graphql
release containing multi-asset support is out