-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cardano-addresses #2066
Bump cardano-addresses #2066
Conversation
bors r+ |
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io>
Build failed |
Regenerating nix fails because of ./nix/regenerate.sh (6s 360ms)
these derivations will be built:
/nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-0.1.1.0.drv
/nix/store/lc1c33qwizwskqya926l429iffsjbkvh-hnix-store-core-lib-hnix-store-core-0.2.0.0-config.drv
/nix/store/jwyw6w770m1aqr30hpavk192723aqz6y-hnix-store-core-lib-hnix-store-core-0.2.0.0-ghc-8.6.5-env.drv
/nix/store/dza3053l9zbxrlxq0sw6zv3hgr90mds7-hnix-store-core-lib-hnix-store-core-0.2.0.0.drv
/nix/store/nqp05d762xfh7b13qrvcrj83r3qr8k09-hnix-lib-hnix-0.8.0-config.drv
/nix/store/7h8x8yr653nn4n4skc2hi798dfmqhsip-hnix-lib-hnix-0.8.0-ghc-8.6.5-env.drv
/nix/store/jbfp7nrs3ar79b6yq7ww73l1kzwhl3c4-hnix-lib-hnix-0.8.0.drv
/nix/store/kxfqi9wc6qza3z0y5znxy5qlakv3ic1v-nix-tools-lib-nix-tools-0.1.0.0-config.drv
/nix/store/jnx4lap268a5dsm3vim4njigk1gkfnj7-nix-tools-lib-nix-tools-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/hxywjd0jc1axnvxhk332395wrch67yhp-nix-tools-lib-nix-tools-0.1.0.0.drv
/nix/store/2q7hb0z0mkzrwysgqh14y947yypnb74l-nix-tools-exe-lts-to-nix-0.1.0.0-config.drv
/nix/store/44yqwwzgmp6w0f5zl10vd1aq2pgw9zya-nix-tools-exe-stack-to-nix-0.1.0.0-config.drv
/nix/store/4pd6qhs3687mskbjz4r52g9mfsbvizix-nix-tools-exe-plan-to-nix-0.1.0.0-config.drv
/nix/store/s9kvyj0sdcqa96mgkh3bamzy9s549s88-nix-tools-exe-stack-repos-0.1.0.0-config.drv
/nix/store/5z5q6anz2b33h2shb088l413qsc3qccg-nix-tools-exe-stack-repos-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/7flrjpkdibh5lwhw67kqwxyj4msh1sz0-nix-tools-exe-hackage-to-nix-0.1.0.0-config.drv
/nix/store/93251rn98bpppayad2frrq6jnwsg32f8-nix-tools-exe-stack-repos-0.1.0.0.drv
/nix/store/j17jy1dnrl4wd54kl266l5a85vr1pjzx-nix-tools-exe-cabal-name-0.1.0.0-config.drv
/nix/store/cn0ws5qarnrghgk0frynsgaki6k1pn6v-nix-tools-exe-cabal-name-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/j8jp8z5ciww94xqnam9qlw1kx3jwgia5-nix-tools-exe-hashes-to-nix-0.1.0.0-config.drv
/nix/store/qg0apmkvsqwmgs2h53gpvj5z1mssra0p-nix-tools-exe-hashes-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/cn3366f5qlvhkns87md51kldvrsgn8n8-nix-tools-exe-hashes-to-nix-0.1.0.0.drv
/nix/store/fswkdg5cyk64p6igvsx0w6wraj6x4vls-nix-tools-exe-plan-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/qbclhhdb5qdvq3jcb3jwzp251xf6cwin-nix-tools-exe-cabal-to-nix-0.1.0.0-config.drv
/nix/store/qqvhdn5bkcsihz0xccfippxcyxr0klsx-nix-tools-exe-cabal-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/gp2k935m7cam3d2zy5kl8dlpap12iadc-nix-tools-exe-cabal-to-nix-0.1.0.0.drv
/nix/store/iwzza3kyzlx4rqys6wnk5api62ysmj3w-nix-tools-exe-lts-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/hj0mlm77in84dzfd0g3f33k4vjmvvmg3-nix-tools-exe-lts-to-nix-0.1.0.0.drv
/nix/store/y6kjmhvdymdvpsybm8v8n514dqmvch8j-nix-tools-exe-stack-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/hw977krma2vpmk04sdn58dla6f7javn4-nix-tools-exe-stack-to-nix-0.1.0.0.drv
/nix/store/iv075y9qr9w69spjdbcf8p1yvwp8y5xc-nix-tools-exe-hackage-to-nix-0.1.0.0-ghc-8.6.5-env.drv
/nix/store/iz42vm7bgcpif535mkqwww8s8k9rsjzw-nix-tools-exe-plan-to-nix-0.1.0.0.drv
/nix/store/jddxx1nyvyymva8hx98ql6j7dma27z65-nix-tools-exe-cabal-name-0.1.0.0.drv
/nix/store/nwn8i9639kmdkmh8lm113x8l4lmlzd0h-nix-tools-exe-hackage-to-nix-0.1.0.0.drv
/nix/store/mbd36wsamk7qb4mx5a0spmhdwpdkj8lv-nix-tools.drv
/nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv
building '/nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-0.1.1.0.drv'...
unpacking sources
unpacking source archive /nix/store/g26wd0dpwr7jj0cnlf3nfrycmjjcc5jp-saltine-0.1.1.0.tar.gz
source root is saltine-0.1.1.0
setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file saltine-0.1.1.0/tests/Util.hs
patching sources
configuring
Configure flags:
--prefix=/nix/store/5v45dsvmymcjsl9n0178w4vdxi4vwwdh-saltine-lib-saltine-0.1.1.0 lib:saltine --package-db=clear --package-db=/nix/store/j7gljbghidmv3sdzw6jvwmi8a59hs782-saltine-lib-saltine-0.1.1.0-config/lib/ghc-8.6.5/package.conf.d --exact-configuration --dependency=profunctors=profunctors-5.5.2-4f1L4urpgFX4DbJxgxiTx3 --dependency=hashable=hashable-1.3.0.0-1RsrIcitxVDKffGN1TuMlm --dependency=rts=rts --dependency=ghc-heap=ghc-heap-8.6.5 --dependency=ghc-prim=ghc-prim-0.5.3 --dependency=integer-gmp=integer-gmp-1.0.2.0 --dependency=base=base-4.12.0.0 --dependency=deepseq=deepseq-1.4.4.0 --dependency=array=array-0.5.3.0 --dependency=ghc-boot-th=ghc-boot-th-8.6.5 --dependency=pretty=pretty-1.1.3.6 --dependency=template-haskell=template-haskell-2.14.0.0 --dependency=ghc-boot=ghc-boot-8.6.5 --dependency=ghc=ghc-8.6.5 --dependency=array=array-0.5.3.0 --dependency=binary=binary-0.8.6.0 --dependency=bytestring=bytestring-0.10.8.2 --dependency=containers=containers-0.6.0.1 --dependency=directory=directory-1.3.3.0 --dependency=filepath=filepath-1.4.2.1 --dependency=ghc-boot=ghc-boot-8.6.5 --dependency=ghc-compact=ghc-compact-0.1.0.0 --dependency=ghc-prim=ghc-prim-0.5.3 --dependency=hpc=hpc-0.6.0.3 --dependency=mtl=mtl-2.2.2 --dependency=parsec=parsec-3.1.13.0 --dependency=process=process-1.6.5.0 --dependency=text=text-1.2.3.1 --dependency=time=time-1.8.0.2 --dependency=transformers=transformers-0.5.6.2 --dependency=unix=unix-2.7.2.2 --dependency=xhtml=xhtml-3000.2.2.1 --with-ghc=ghc --with-ghc-pkg=ghc-pkg --with-hsc2hs=hsc2hs --with-gcc=cc --with-ld=ld --with-ar=ar --with-strip=strip --disable-executable-stripping --disable-library-stripping --disable-library-profiling --disable-executable-profiling --enable-static --enable-shared
Configuring library for saltine-0.1.1.0..
Warning: The flag --disable-executable-profiling is deprecated. Please use
--disable-profiling instead.
Setup: Missing dependency on a foreign library:
* Missing (or bad) C library: sodium
This problem can usually be solved by installing the system package that
provides this library (you may need the "-dev" version). If the library is
already installed but in a non-standard location then you can use the flags
--extra-include-dirs= and --extra-lib-dirs= to specify where it is.If the
library file does exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.
builder for '/nix/store/d6k5nb583v6ghskqjiwy4q57a8fzlv92-saltine-lib-saltine-0.1.1.0.drv' failed with exit code 1
cannot build derivation '/nix/store/lc1c33qwizwskqya926l429iffsjbkvh-hnix-store-core-lib-hnix-store-core-0.2.0.0-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dza3053l9zbxrlxq0sw6zv3hgr90mds7-hnix-store-core-lib-hnix-store-core-0.2.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nqp05d762xfh7b13qrvcrj83r3qr8k09-hnix-lib-hnix-0.8.0-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jbfp7nrs3ar79b6yq7ww73l1kzwhl3c4-hnix-lib-hnix-0.8.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gp2k935m7cam3d2zy5kl8dlpap12iadc-nix-tools-exe-cabal-to-nix-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nwn8i9639kmdkmh8lm113x8l4lmlzd0h-nix-tools-exe-hackage-to-nix-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/cn3366f5qlvhkns87md51kldvrsgn8n8-nix-tools-exe-hashes-to-nix-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hj0mlm77in84dzfd0g3f33k4vjmvvmg3-nix-tools-exe-lts-to-nix-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/iz42vm7bgcpif535mkqwww8s8k9rsjzw-nix-tools-exe-plan-to-nix-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kxfqi9wc6qza3z0y5znxy5qlakv3ic1v-nix-tools-lib-nix-tools-0.1.0.0-config.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hxywjd0jc1axnvxhk332395wrch67yhp-nix-tools-lib-nix-tools-0.1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mbd36wsamk7qb4mx5a0spmhdwpdkj8lv-nix-tools.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv': 1 dependencies couldn't be built
error: build of '/nix/store/vpjssbczqhhsfg31ndsfk42s92w96rf9-nix-tools-regenerate.drv' failed |
Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59)
adef64a
to
fc381dd
Compare
Thanks @rvl! |
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
It looks like the regenerate script may not work on macos. CI only builds it for linux at the moment. |
Canceled |
bors r+ |
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed
|
bors r+ |
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failedMac failure:
|
bors r+ |
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failedlinux:
|
bors r+ |
2066: Bump cardano-addresses r=Anviking a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed
|
Oh, this might be a real problem, not just flakiness 🤦♂️ |
bors try |
tryBuild failed
|
bors r+ |
2066: Bump cardano-addresses r=KtorZ a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2080: Also trace the times of stake distribution LSQ queries r=Anviking a=Anviking # Issue Number #2005 / new issue # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Also measure and trace the times of the LSQ queries in the `stakeDistribution` function # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
This PR was included in a batch that timed out, it will be automatically retried |
2066: Bump cardano-addresses r=KtorZ a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failedUnit tests failed due to #2064. |
bors r+ |
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2071: Minor nix cleanups r=rvl a=rvl ### Issue Number #2046 #2054 ### Overview - Minor cleanups of nix code for migration tests and latency benchmark. ### Comments Tested with: ``` nix-build -A benchmarks.cardano-wallet.latency nix-build nix/migration-tests.nix ``` 2080: Also trace the times of stake distribution LSQ queries r=rvl a=Anviking # Issue Number #2005 / new issue # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Also measure and trace the times of the LSQ queries in the `stakeDistribution` function # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2087: Transaction metadata in swagger API spec r=rvl a=rvl ### Issue Number ADP-307 / #2073 / #2074 ### Overview Updates the swagger spec for the new metadata field when: - listing transactions (metadata field is always present but may be null) - posting a transaction (metadata field is optional) - estimating fee (as above) ### Comments [Rendered spec](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/input-output-hk/cardano-wallet/rvl/2073/swagger/specifications/api/swagger.yaml) Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build failed (retrying...)PR #2087 part of the batch had a test failure. |
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> 2071: Minor nix cleanups r=rvl a=rvl ### Issue Number #2046 #2054 ### Overview - Minor cleanups of nix code for migration tests and latency benchmark. ### Comments Tested with: ``` nix-build -A benchmarks.cardano-wallet.latency nix-build nix/migration-tests.nix ``` Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failed (retrying...)Unit tests failed due to #2064. |
2066: Bump cardano-addresses r=rvl a=Anviking # Issue Number Release. # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Bump cardano-addresses # Comments - I believe this purely affects CLI usage of the cardano-addresses binary that will get included in the wallet release ``` Bump includes: - [Increase default mnemonic phrase length](IntersectMBO/cardano-addresses#53) - [Allow to inspect reward accounts wrt #46](IntersectMBO/cardano-addresses#56) - [Allow to generate stake addresses #58](IntersectMBO/cardano-addresses#58) - [Make 'payment' subcommand generate testnet hrp, wrt #55](IntersectMBO/cardano-addresses#59) ``` <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <johannes.lund@iohk.io> Co-authored-by: IOHK <devops+stack-project@iohk.io> Co-authored-by: Rodney Lorrimar <rodney.lorrimar@iohk.io>
Build failedUnit tests failed due to #2064. |
bors r+ |
Build succeeded |
Issue Number
Release.
Overview
Comments