Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata to transaction layer #2090

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Add metadata to transaction layer #2090

merged 2 commits into from
Sep 1, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 28, 2020

Issue Number

ADP-307 / #2073

Overview

  • Adds metadata as a parameter of mkStdTx so that transactions can be submitted with metadata.

Comments

Based on the branch of PR #2079.

@rvl rvl added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Aug 28, 2020
@rvl rvl added this to the (ADP-307) Transaction metadata milestone Aug 28, 2020
@rvl rvl self-assigned this Aug 28, 2020
@rvl rvl mentioned this pull request Aug 28, 2020
Merged
KtorZ
KtorZ reviewed Aug 31, 2020
View reviewed changes
lib/core/src/Cardano/Wallet.hs Outdated
@@ -1591,6 +1592,7 @@ signTx ctx wid pwd (UnsignedTx inpsNE outsNE) = db & \DBLayer{..} -> do
nl = ctx ^. networkLayer @t
inps = NE.toList inpsNE
outs = NE.toList outsNE
md = Nothing -- no metadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be better left as an argument as well ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably - fixed.

Base automatically changed from rvl/2077/tx-metadata to master September 1, 2020 04:12
@rvl
Copy link
Contributor Author

rvl commented Sep 1, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Sep 1, 2020
@iohk-bors
Try #2090:
79b12b2
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 1, 2020

try

Build succeeded

@KtorZ KtorZ merged commit efe5201 into master Sep 1, 2020
@KtorZ KtorZ deleted the rvl/2073/mkstdtx branch September 1, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees

@rvl rvl

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
(ADP-307) Transaction metadata
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @KtorZ