Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address slow fee estimation on Byron wallets #2128

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Address slow fee estimation on Byron wallets #2128

merged 3 commits into from
Sep 9, 2020

Commits on Sep 9, 2020

  1. extend post-restoration benchmark wallet overview with number of addr… 

    …esses and transactions

  We had only the UTxO, which gave little clarity about how many addresses and transactions did that correspond to. In practice, they're of the same order of magnitude, but it's good to have the actual number.
    @KtorZ
    KtorZ committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    5f274e6 View commit details
    Browse the repository at this point in the history

  2. do not construct dummy bootstrap witnesses but apply a correction on … 

    …shelley witnesses afterwards

  This is slightly simpler, but it also prevent some nasty things happening with the bootstrap witnesses: the 'Ord' instances used to compare and sort bootstrap witnesses require to serialize them fully, which involve two hashes of bytestrings; when done for 50 inputs, and 100 times in a row in multiple selection this little thing start to matter quite a lot.
    @KtorZ
    KtorZ committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    6c4b1c8 View commit details
    Browse the repository at this point in the history

  3. adjust byron migration test assertion due to recent change 

      The fee estimation is now slightly faster, but the approximation is slightly worse, so we end up paying a little more for byron witnesses.
    @KtorZ
    KtorZ committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3e628f0 View commit details
    Browse the repository at this point in the history