Skip to content

Add 10 min timeout to Test.Hspec.Extra.it #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

Add 10 min timeout to Test.Hspec.Extra.it #2194

merged 1 commit into from
Oct 2, 2020

Conversation

@Anviking
Copy link
Member

@Anviking Anviking commented Sep 30, 2020

Issue Number

#2192

Overview

  • Add 10 min timeout to it.

Comments

@Anviking Anviking self-assigned this Sep 30, 2020
@Anviking Anviking changed the base branch from master to anviking/2192/test-custom-it September 30, 2020 12:42
@Anviking Anviking force-pushed the anviking/2192/it-timeout branch from eb1507e to c888f51 Compare September 30, 2020 12:43
Anviking
Anviking commented Sep 30, 2020
View reviewed changes
@Anviking Anviking requested a review from KtorZ September 30, 2020 13:08
@Anviking
Copy link
Member Author

Anviking commented Sep 30, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Sep 30, 2020
@iohk-bors
Try #2194:
8db3c9e
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 30, 2020 •
edited by Anviking
Loading

try

Build failed:

hlint

@Anviking
Copy link
Member Author

Anviking commented Sep 30, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Sep 30, 2020
@iohk-bors
Try #2194:
4bf6f30
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 30, 2020

try

Build succeeded:

KtorZ
KtorZ reviewed Oct 1, 2020
View reviewed changes
@Anviking Anviking force-pushed the anviking/2192/it-timeout branch 2 times, most recently from 01a21e7 to 88419c7 Compare October 1, 2020 13:31
@Anviking Anviking force-pushed the anviking/2192/test-custom-it branch from 28d90fb to b0c85e0 Compare October 1, 2020 14:46
@Anviking
Copy link
Member Author

Anviking commented Oct 1, 2020

@KtorZ may you also look at #2193 too, which this depends on? 🙏

@Anviking
Add a 10 min timeout to it
e9b6db0 
Instead of causing the CI to timeout, we should now get the test causing
the timeout to fail.

Also:

Simplify itWithCustomTimeout implementation

with Matthias suggestion.
@Anviking Anviking force-pushed the anviking/2192/it-timeout branch from 88419c7 to e9b6db0 Compare October 1, 2020 14:53
Base automatically changed from anviking/2192/test-custom-it to master October 2, 2020 05:44
@Anviking
Copy link
Member Author

Anviking commented Oct 2, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 2, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit b9bc46b into master Oct 2, 2020
@iohk-bors iohk-bors bot deleted the anviking/2192/it-timeout branch October 2, 2020 07:05
@Anviking Anviking mentioned this pull request Oct 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@KtorZ KtorZ KtorZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Anviking Anviking

Labels

None yet

Projects

None yet

Milestone

(ADP-419) Make integration test outpu...

Development

Successfully merging this pull request may close these issues.

3 participants

@Anviking @KtorZ