Update to GHC 9.6.4 and HLS 2.6.0.0. #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like HLS is getting stuck after the update to 2.6.0.0 (see https://buildkite.com/cardano-foundation/cardano-wallet/builds/3344#018d7d17-3a31-4fed-81c0-db547420cb0f): After a while, the log has the following entries: After the above log entries, there is no further progress (except for memory usage reports), even after 1 hour: Perhaps this is related to haskell/haskell-language-server#4046. |
jonathanknowles
changed the title
nix/haskell.nix
Outdated
Comment on lines
152
to
154
| (haskell-nix.tool "ghc963" "haskell-language-server" ({pkgs, ...}: rec { | ||
| (haskell-nix.tool "ghc964" "haskell-language-server" ({pkgs, ...}: rec { | ||
| # Use the github source of HLS that is tested with haskell.nix CI | ||
| src = pkgs.haskell-nix.sources."hls-2.5"; | ||
| src = pkgs.haskell-nix.sources."hls-2.6"; |
There was a problem hiding this comment.
What if you simply don't bump HLS, i.e. leave it at gh963 and hls-2.5?
This will bring both GHC 9.6.4 and GHC 9.6.3 into the nix store. Not sure if that's worth it.
HLS wants to be a special snowflake, that's why the dependency information is different from the other tools. 😅
There was a problem hiding this comment.
patch applied, cardano-scaling/hydra@0b8776a
seems working
There was a problem hiding this comment.
@paolino nice!
paolino
force-pushed
the
jonathanknowles/ghc-9.6.4
branch
from
df8b8e0 to
0915376
Compare
jonathanknowles
force-pushed
the
jonathanknowles/ghc-9.6.4
branch
from
0915376 to
b3acad0
Compare
1 task
HeinrichApfelmus
approved these changes
Feb 8, 2024
|
Merging, following the decision here: https://cardanofoundation.slack.com/archives/C05GW7ZF508/p1707389698859199?thread_ts=1707381709.848279&cid=C05GW7ZF508 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the versions of GHC and HLS used in our nix configuration: