Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cip-1694-ui): inject env vars via script #447

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(cip-1694-ui): inject env vars via script #447

merged 1 commit into from
Oct 11, 2023

Conversation

vetalcore
Copy link
Collaborator

How to test locally:

  • remove .env files if present (otherwise it would be taken as a source)
  • run docker build -t cip1694-ui:latest .
  • run docker run -it --rm -e REACT_APP_EVENT_ID=WHATEVER1 -p 8080:8080 cip1694-ui:latest, the -e REACT_APP_blabla=http://shwatever/ allows you to pass env vars to the docker container
  • open an app on localhost:8080
  • check network tab that should make post request with proper event id

@vetalcore vetalcore requested a review from kickloop October 10, 2023 14:39
@vetalcore vetalcore self-assigned this Oct 10, 2023
@vetalcore vetalcore force-pushed the fix/inject-env-via-script branch from 2400494 to a85b02b Compare October 10, 2023 14:43
@nemo83 nemo83 merged commit 4209ee8 into main Oct 11, 2023
@nemo83 nemo83 deleted the fix/inject-env-via-script branch October 11, 2023 10:23
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kickloop kickloop kickloop approved these changes

Assignees

@vetalcore vetalcore

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vetalcore @kickloop @nemo83