Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alba-rust Error handling #6

Open
curiecrypt opened this issue Jun 26, 2024 · 1 comment
Open

Alba-rust Error handling #6

curiecrypt opened this issue Jun 26, 2024 · 1 comment
Assignees
@rrtoledo
Labels
enhancement New feature or request
Milestone
0.1

Comments

@curiecrypt
Copy link
Collaborator

curiecrypt commented Jun 26, 2024 •
edited by rrtoledo
Loading

Implement proper error handling for the necessary cases.

Add error when nf> np
@curiecrypt curiecrypt added the enhancement New feature or request label Jun 26, 2024
@ghost ghost added this to the 0.1 milestone Sep 5, 2024
@rrtoledo
Copy link
Collaborator

Future reminder: When we implement the errors, we definitely should specify in which case we return none.
Also, it could be useful to explain the difference between returning an empty proof or none in the docs.

@rrtoledo rrtoledo self-assigned this Dec 3, 2024
This was referenced Dec 13, 2024
Closed
Merged
rrtoledo added a commit that referenced this issue Dec 16, 2024
@rrtoledo
Fixing lottery (#105)
97d63f2 
## Content

The lottery parameters does not check that the computed proof size
`proof_size > lower_bound` or even `proof_size > set_size`.
This PR returns proof_size=lower_bound if the lower bound is lower than
the computed u.

## Pre-submit checklist

- Branch
    - [ ] Tests are provided (if possible)
    - [x] Commit sequence broadly makes sense
    - [x] Key commits have useful messages
- PR
    - [x] No clippy warnings in the CI
    - [x] Self-reviewed the diff
    - [x] Useful pull request description
    - [x] Reviewer requested
- Documentation
    - [ ] Update README file (if relevant)
    - [ ] Update documentation website (if relevant)

## Comments
We will chech that lower_bound < set_size in issue #6 
 
## Issue(s)

<!-- The issue(s) this PR relates to or closes -->

Relates to #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrtoledo rrtoledo

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@rrtoledo @curiecrypt