Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra clean updates #1731

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

oduameh
Copy link
Contributor

@oduameh oduameh commented Oct 31, 2024


This PR suggests some minor edits throughout the docs, mostly typos or capitalization fixes.

@olgahryniuk olgahryniuk added the documentation 📖 Documentation changes label Nov 1, 2024
docs/benchmarks/index.md Outdated Show resolved Hide resolved
@@ -2,98 +2,42 @@

Additional implementation-specific documentation for the Hydra Head protocol and extensions like incremental decommits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has happened here? Please revert the changes here; I can't tell what has changed (should be nothing.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @noonio, nothing has changed here. The content was accidentally removed, but I have added it back, untouched and unmodified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oduameh this still doesn't seem right:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @noonio, this has now been fixed apologies for the mixup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look @oduameh ; unfortunately the problem still persists.

Please check it yourself after you have pushed a commit by coming to this page https://github.com/cardano-scaling/hydra/pull/1731/files and making sure there are no changes in this file; docs/docs/dev/protocol.md.

docs/docs/tutorial/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@noonio noonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these.

Mostly some useful changes; I've provided some feedback to be addressed on some others, then it should be ready to merge!

@oduameh
Copy link
Contributor Author

oduameh commented Nov 5, 2024

Hi @noonio, thank you for your feedback. Other than the UTXO instances we discussed, all other changes have been implemented.

olgahryniuk and others added 6 commits November 6, 2024 13:13
Co-authored-by: olgahryniuk <67585499+olgahryniuk@users.noreply.github.com>
Co-authored-by: olgahryniuk <67585499+olgahryniuk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants