-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydra clean updates #1731
base: master
Are you sure you want to change the base?
Hydra clean updates #1731
Conversation
docs/docs/dev/protocol.md
Outdated
@@ -2,98 +2,42 @@ | |||
|
|||
Additional implementation-specific documentation for the Hydra Head protocol and extensions like incremental decommits. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has happened here? Please revert the changes here; I can't tell what has changed (should be nothing.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @noonio, nothing has changed here. The content was accidentally removed, but I have added it back, untouched and unmodified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oduameh this still doesn't seem right:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @noonio, this has now been fixed apologies for the mixup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look @oduameh ; unfortunately the problem still persists.
Please check it yourself after you have pushed a commit by coming to this page https://github.com/cardano-scaling/hydra/pull/1731/files and making sure there are no changes in this file; docs/docs/dev/protocol.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these.
Mostly some useful changes; I've provided some feedback to be addressed on some others, then it should be ready to merge!
c17c7f7
to
cf26b59
Compare
Hi @noonio, thank you for your feedback. Other than the UTXO instances we discussed, all other changes have been implemented. |
1e487d1
to
cf26b59
Compare
Co-authored-by: olgahryniuk <67585499+olgahryniuk@users.noreply.github.com>
Co-authored-by: olgahryniuk <67585499+olgahryniuk@users.noreply.github.com>
cf26b59
to
e48414e
Compare
This PR suggests some minor edits throughout the docs, mostly typos or capitalization fixes.