Improvements #2
Merged
Improvements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the verbosity which is stored to check if a level is enabled
This should reduce the number of syscalls, and locks around stderr
cardoe
approved these changes
Sep 3, 2017
cardoe
added a commit
that referenced
this pull request
Sep 3, 2017
As of #2, the lowest supported version is actually 1.17.0.
|
Actually I'm going to hold off pushing a release because my use case needs Rust 1.15.1 and these changes bumped the minimum version to 1.17.0. Going to try and come up with a workaround to support older versions still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.