Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
habdelra committed Mar 28, 2024
1 parent d6e8936 commit 2aa5cb7
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions packages/runtime-common/indexer/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,13 @@ export class IndexerDBClient {
]);
}

// TODO handle containsMany fields. Take a look at how FieldArity works in hub
// v2 for an example which let's us use a different card expression for
// singular fields vs plural fields. Also plural fields will really push
// SQLite to the extreme in terms of the query that we need--this is
// challenging because the original hub v2 implementation leveraged array
// operators for this query which SQLite does not have.
// TODO handle containsMany fields. We should load the field for the `onRef`
// and see if it's a containsMany or not. based on that we'd return a
// different CardExpression (take a look at hub v2 for an example). Also
// plural fields will really push SQLite to the extreme in terms of the query
// that we need--this is challenging because the original hub v2
// implementation leveraged array operators for this query which SQLite does
// not have.
private fieldFilter(
key: string,
value: JSONTypes.Value,
Expand Down

0 comments on commit 2aa5cb7

Please sign in to comment.