Avoid reprocessing matrix events #2127
Closed
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host Test Results 1 files ±0 1 suites ±0 24m 5s ⏱️ +12s For more details on these errors, see this check. Results for commit 594dd5a. ± Comparison against base commit 106d397. ♻️ This comment has been updated with latest results. |
lukemelia
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a single message to the bot and single chunk reply results in reprocessing the entire event list 14-15 times for a room. This skips which events we've processed before.
To deal with things that are out of order, this actually just reprocesses events from the first unseen event.
Even with this we still seem to try calling load room quite a lot, this PR just lowers the cost of doing so, and makes it a bit simpler where we want to start doing auto calling of commands.
Potentially this needs to change to more strictly process the events once.