Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember builds with non-portable addon bundles #122

Merged
merged 26 commits into from
Mar 12, 2021
Merged

Ember builds with non-portable addon bundles #122

merged 26 commits into from
Mar 12, 2021

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Mar 12, 2021

Fixes #CS-207. This update adds support for ember builds with non portable bundles. Note that this currently relies upon a hacked version of embroider. To use this:

  1. Yarn link the @embroider/core and @embroider/compat packages from the catalogjs-experiment branch of the https://github.com/ef4/snowpack-experiment repo to the packages/ember-app workspace in this repository. (This step eventually goes away after some key upstream embroider changes are made available).

  2. Update the packages/src/core/babel-plugin-adjust-imports.ts#adjustSpecifier method to indicate if the build is using the file daemon or not (runningInsideFileDaemon variable), and recompile the TypeScript.

there is a new yarn script for serving the ember app:
yarn serve:ember-app (for hosted pkgs)
yarn serve:ember-app-local-pkgs (for local pkgs)

This will both start ember s and run the file daemon pointed to the embroider stage 2 outputs of the ember build.
(additionally the old test-app serving has been moved to yarn serve:test-app

To generate the ember-app bundles, there is a yarn script, yarn ember-acceptance-test that will generate the bundles for the ember-app. eventually this will be the full acceptance tests for teh ember app after the next phase of work is completed. Make sure the hacked embroider is set to runningInsideFileDaemon = false and TS compiled before making the bundles.

ef4 and others added 26 commits March 2, 2021 13:35
Co-authored-by: Hassan Abdel-Rahman <hassan.abdelrahman@gmail.com>
Co-authored-by: Matt McManus <matt@mcmanus.io>
@habdelra habdelra merged commit 12fd2a9 into master Mar 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the ember branch March 12, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants