-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember builds with non-portable addon bundles #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort exists in the module
… the full package name
…uild ember-app catalogjs bundles
…el plugin runs in the node build stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #CS-207. This update adds support for ember builds with non portable bundles. Note that this currently relies upon a hacked version of embroider. To use this:
Yarn link the
@embroider/core
and@embroider/compat
packages from thecatalogjs-experiment
branch of the https://github.com/ef4/snowpack-experiment repo to thepackages/ember-app
workspace in this repository. (This step eventually goes away after some key upstream embroider changes are made available).Update the
packages/src/core/babel-plugin-adjust-imports.ts#adjustSpecifier
method to indicate if the build is using the file daemon or not (runningInsideFileDaemon
variable), and recompile the TypeScript.there is a new yarn script for serving the ember app:
yarn serve:ember-app
(for hosted pkgs)yarn serve:ember-app-local-pkgs
(for local pkgs)This will both start
ember s
and run the file daemon pointed to the embroider stage 2 outputs of the ember build.(additionally the old test-app serving has been moved to
yarn serve:test-app
To generate the ember-app bundles, there is a yarn script,
yarn ember-acceptance-test
that will generate the bundles for the ember-app. eventually this will be the full acceptance tests for teh ember app after the next phase of work is completed. Make sure the hacked embroider is set torunningInsideFileDaemon = false
and TS compiled before making the bundles.