Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help with usage for crates with multiple binaries #1380

Open
andrewdavidmackenzie opened this issue Sep 22, 2023 · 6 comments · May be fixed by #1450
Open

Help with usage for crates with multiple binaries #1380

andrewdavidmackenzie opened this issue Sep 22, 2023 · 6 comments · May be fixed by #1450

Comments

@andrewdavidmackenzie
Copy link

I have looked for this in Support.md and elsewheer but have not found it yet, appologies if it is already documented.

I have a crate (flowr) that is part of a workspace project (flow) that builds multiple binaries (flowrcli, flowrgui, flowrex).
In the same workspace project I have a crate flowc that builds a binary flowc.

I have been able to use cargo binstall to install flowc without problems, as it can find the flowc binary asset in releases.

How can I use (i.e. command line options required) cargo binstall to install all the binaries of the flowr crate?

thanks

@NobodyXu
Copy link
Member

There are two solutions to this problem.

The first solution is to put all the binaries into a single achieve flowr-{ version }-{ target }.tar.gz, then cargo-binstall should work out-of-the-box.

The other solution is to wait for #854 to be implemented in cargo-binstall, since your release contains a disr-manifest.json

@NobodyXu
Copy link
Member

I will prioritize this issue since I think supporting this use case is important.

@NobodyXu
Copy link
Member

NobodyXu commented Sep 23, 2023

P.S. @andrewdavidmackenzie Your flowr is also using very old cargo-dist, we will probably only support newer version (>0.0.2) of cargo-dist.

@andrewdavidmackenzie I've opened andrewdavidmackenzie/flow#2053 to use latest cargo-dist in flow

@andrewdavidmackenzie
Copy link
Author

Thanks for the advice, work and PR. I will look at this tomorrow night.

@andrewdavidmackenzie
Copy link
Author

Do you recommend I wait for you to implement #854 then?

@NobodyXu
Copy link
Member

Do you recommend I wait for you to implement #854 then?

Yes, I am working on it.

@NobodyXu NobodyXu linked a pull request Oct 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants