Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest cargo-dist in CI release.yml #2053

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

NobodyXu
Copy link
Contributor

cargo-dist v0.0.2 is too old and its dist-manifest.json is deprecated.

Hard-coding specific version of cargo-dist is also not good enough, so I use taiki-e/install-action which uses cargo-binstall to install latest stable version of cargo-dist.

`cargo-dist` v0.0.2 is too old and its `dist-manifest.json` is deprecated.

Hard-coding specific version of `cargo-dist` is also not good enough, so I use [taiki-e/install-action](https://github.com/taiki-e/install-action) which uses `cargo-binstall` to install latest stable version of `cargo-dist`.
@andrewdavidmackenzie
Copy link
Owner

I'll have to do a new release to see this in action...

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c445e8c) 88% compared to head (a4fab76) 88%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2053   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         151     151           
  Lines       18636   18636           
======================================
- Hits        16397   16396    -1     
- Misses       2239    2240    +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NobodyXu
Copy link
Contributor Author

I'll have to do a new release to see this in action...

That's right, but taiki-e/install-action should be ok and works as expected.
I used it elsewhere a lot and it works pretty well for me.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 8f22cba into andrewdavidmackenzie:master Sep 26, 2023
@NobodyXu NobodyXu deleted the patch-1 branch September 26, 2023 10:49
@andrewdavidmackenzie
Copy link
Owner

My attempted release build just failed:

https://github.com/andrewdavidmackenzie/flow/actions/runs/6336321291

I'll need to investigate the change that caused that...

@andrewdavidmackenzie
Copy link
Owner

Now I'm getting

https://github.com/andrewdavidmackenzie/flow/actions/runs/6337614224/job/17213088113

this update to cargo-dist has broken my release workflow.

Any ideas @NobodyXu on what I need to configure for cargo-dist to work again?

@NobodyXu
Copy link
Contributor Author

@andrewdavidmackenzie I think you will need to run cargo dist init again since newer version of cargo-dist has different configuration.

@andrewdavidmackenzie
Copy link
Owner

Running it locally does nothing

andrew@MacBook-Pro flow % cargo dist init
[profile.dist] already exists, nothing to do
[workspace.metadata.dist] already exists, nothing to do

I tried running it in CI and gave the error above :-(

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Sep 28, 2023

@andrewdavidmackenzie Not an expert in this, but maybe you need to also upgrade your cargo-dist locally?

Maybe also try removing profile.dist and workspace.metadata.dist, I read that the dist-manifest.json itself changes a lot between cargo-dist v0.0.2 and and v0.2, maybe a fresh re-initialization is required

@andrewdavidmackenzie
Copy link
Owner

now

https://github.com/andrewdavidmackenzie/flow/actions/runs/6342367860/job/17227974434

I'm starting to wish I never touched this, and have to learn all this cargo-dist stuff, and it's failures from scratch - meanwhile release CI is broken :-(

@NobodyXu
Copy link
Contributor Author

@andrewdavidmackenzie According to cargo-dist doc, cargo dist init can also generate release.yml, so maybe you also need to remove that and just let cargo-dist does the magic for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants