-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest cargo-dist
in CI release.yml
#2053
Use latest cargo-dist
in CI release.yml
#2053
Conversation
`cargo-dist` v0.0.2 is too old and its `dist-manifest.json` is deprecated. Hard-coding specific version of `cargo-dist` is also not good enough, so I use [taiki-e/install-action](https://github.com/taiki-e/install-action) which uses `cargo-binstall` to install latest stable version of `cargo-dist`.
I'll have to do a new release to see this in action... |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2053 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 151 151
Lines 18636 18636
======================================
- Hits 16397 16396 -1
- Misses 2239 2240 +1 ☔ View full report in Codecov by Sentry. |
That's right, but |
My attempted release build just failed: https://github.com/andrewdavidmackenzie/flow/actions/runs/6336321291 I'll need to investigate the change that caused that... |
Now I'm getting https://github.com/andrewdavidmackenzie/flow/actions/runs/6337614224/job/17213088113 this update to cargo-dist has broken my release workflow. Any ideas @NobodyXu on what I need to configure for cargo-dist to work again? |
@andrewdavidmackenzie I think you will need to run |
Running it locally does nothing
I tried running it in CI and gave the error above :-( |
@andrewdavidmackenzie Not an expert in this, but maybe you need to also upgrade your Maybe also try removing |
now https://github.com/andrewdavidmackenzie/flow/actions/runs/6342367860/job/17227974434 I'm starting to wish I never touched this, and have to learn all this cargo-dist stuff, and it's failures from scratch - meanwhile release CI is broken :-( |
@andrewdavidmackenzie According to cargo-dist doc, |
cargo-dist
v0.0.2 is too old and itsdist-manifest.json
is deprecated.Hard-coding specific version of
cargo-dist
is also not good enough, so I use taiki-e/install-action which usescargo-binstall
to install latest stable version ofcargo-dist
.