Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo root determination to be more similar to cargo-install #859

Closed
NobodyXu opened this issue Mar 5, 2023 · 1 comment · Fixed by #884
Closed

Fix cargo root determination to be more similar to cargo-install #859

NobodyXu opened this issue Mar 5, 2023 · 1 comment · Fixed by #884

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Mar 5, 2023 •
edited
Loading

cargo-install determins cargo root in the following order:

cargo-binstall lacks the ability to parse install.root cargo config value, which makes its behavior a little bit different from cargo-install.

Also, cargo-install uses --root for specifying alternative cargo root, but cargo-binstall uses --roots.
Perhaps we should also rename that option @passcod , which will be a breaking change though?
@NobodyXu NobodyXu mentioned this issue Mar 5, 2023
Closed
8 tasks
@passcod
Copy link
Member

passcod commented Mar 5, 2023

Let's rename but add an alias to the old one

@NobodyXu NobodyXu changed the title Fix cargo root determination to be more similar to carog-install Fix cargo root determination to be more similar to cargo-install Mar 5, 2023
@NobodyXu NobodyXu mentioned this issue Mar 11, 2023
Merged
NobodyXu added a commit that referenced this issue Mar 16, 2023
@NobodyXu
Use install.root in $CARGO_HOME/config.toml (#884)
58b7044 
Fixed #859

* Impl `cargo_config`
* Use `install.root` in `$CARGO_HOME/.cargo/config.toml`
   before fallback to `cargo_home`.
* Improve logging in `get_cargo_roots_path`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use install.root in $CARGO_HOME/config.toml cargo-bins/cargo-binstall
2 participants
@passcod @NobodyXu