Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Extract new crate binstalk-registry #1289

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Refactor: Extract new crate binstalk-registry #1289

merged 1 commit into from
Aug 13, 2023

Conversation

NobodyXu
Copy link
Member

To speedup codegen of binstalk and enable it to be reused.

@NobodyXu NobodyXu force-pushed the refactor-drivers branch 2 times, most recently from b2fa2cb to 22c4dbe Compare August 13, 2023 05:47
@NobodyXu
Refactor: Extract new crate binstalk-registry
8291f95 
To speedup codegen of `binstalk` and enable it to be reused.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu changed the title Refactor: Extract new crate binstalk-drivers Refactor: Extract new crate binstalk-registry Aug 13, 2023
@NobodyXu
Copy link
Member Author

@Byron This PR extracts mod binstalk::drivers out as a new crate binstalk-registry.
I decided to relicense it to MIT/Apache, so I would need your permission.

@Byron
Copy link
Contributor

Byron commented Aug 13, 2023

I don't remember any of it 😅.
I hereby grant permission to relicense the code to MIT/Apache.

@NobodyXu
Copy link
Member Author

Thanks @Byron , it's from #1207 where you modified crates/binstalk/src/drivers/registry/git_registry.rs.

@NobodyXu NobodyXu requested a review from passcod August 13, 2023 06:02
@NobodyXu NobodyXu enabled auto-merge August 13, 2023 06:02
@NobodyXu NobodyXu mentioned this pull request Aug 13, 2023
Closed
@NobodyXu NobodyXu added this pull request to the merge queue Aug 13, 2023
Merged via the queue into main with commit 623f7ff Aug 13, 2023
@NobodyXu NobodyXu deleted the refactor-drivers branch August 13, 2023 07:41
@NobodyXu
Copy link
Member Author

@passcod Invitation has been sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passcod passcod passcod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NobodyXu @Byron @passcod