Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: faster self-install without rate limit issue #1963

Merged
merged 32 commits into from
Nov 9, 2024
Merged

feature: faster self-install without rate limit issue #1963

merged 32 commits into from
Nov 9, 2024

Conversation

NobodyXu
Copy link
Member

@NobodyXu NobodyXu commented Nov 7, 2024

Bypassing re-downloading altogether by having a special mode that directly copy the file and then update .cargo manifest.

NobodyXu added 17 commits November 6, 2024 12:03
@NobodyXu
Add new hidden option --self-install
d8464ac 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix typo
0400688 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Optimize: Only call LazyJobserverClient::new when necessary
9c20b3c 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
--self-install should include a path to a binary
38f15ee 
On windows, we cannot just copy an executable with process running from it, so better to copy it to a temporary location.

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Impl manifest update and basic API of self_install
2d68ade 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Add dep atomic-file-install to cargo-binstall
273a4e8 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Impl self_install
40a9033 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Make --self-install a boolean flag
65ca3d5 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Accept no duration in MainExit::new
142d53d 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Impl self-install mode in main_impl.rs
173cda5 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Use --self-install mode in install-from-binstall-release.sh
1f211d4 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Use --self-install in install-from-binstall-release.ps1
5107b51 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Merge branch 'main' into feature/self-install
fdc4a1f 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix import in mod entry
90ab7d4 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix call of self_install in main_impl
91e3b4c 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix --self-install clap doc
5e7d54e 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix entry::self_install
5cc8d05 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
NobodyXu
NobodyXu commented Nov 7, 2024
View reviewed changes
install-from-binstall-release.ps1 Outdated Show resolved Hide resolved
install-from-binstall-release.sh Outdated Show resolved Hide resolved
NobodyXu added 12 commits November 8, 2024 00:50
@NobodyXu
Apply suggestions from code review
15e775a 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix parsing semver number in entry.rs
b06d6a2 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix compilation in entry.rs
2af41d0 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
fix entry.rs
e0c646e 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in bin_util.rs
36109cb 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix fmt in entry.rs
2e6fe97 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Use --self-install if supported in unix install script
49c0833 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Use --self-install if available in powershell install script
234aa2a 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix install-from-binstall-release.ps1
60c6411 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fi install-from-binstall-release.ps1
0cad38b 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix install-from-binstall-release.ps1
5d4ac2e 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Create self-install.sh
2afabb9 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Add e2e-test-self-install to justfile
a542961 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu NobodyXu added this pull request to the merge queue Nov 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2024
@NobodyXu
Fix args::parse() for self-install mode
19151ad 
Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu
Fix args parsing: Do no require positional arg if --self-install is p…
53da569 
…resent

Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
@NobodyXu NobodyXu enabled auto-merge November 9, 2024 06:17
@NobodyXu NobodyXu added this pull request to the merge queue Nov 9, 2024
Merged via the queue into main with commit c9d5e6d Nov 9, 2024
34 checks passed
@NobodyXu NobodyXu deleted the feature/self-install branch November 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NobodyXu