Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended local planner with a lateral offset #3678

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

glopezdiest
Copy link
Contributor

@glopezdiest glopezdiest commented Dec 7, 2020

Description

Added an offset input to the VehiclePIDController, allowing the controlled vehicles to move displaced from the lane center. The LocalPlanner has been extended to accomodate these changes.

It is important to note that due to the current state of the controllers, they are subject to break if the offset is high enough to make the vehicle drive through an adjacent lane. This is mainly due to the use of functions such as get_waypoint() or is_at_traffic_light().

Where has this been tested?

  • Platform(s): Ubuntu 18.04
  • Python version(s): 3.6
  • Unreal Engine version(s): 4.24

Possible Drawbacks

There should be no possible drawbacks as this is purely an extension.


This change is Reviewable

Copy link
Contributor

@jackbart94 jackbart94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pravinblaze)

Copy link
Contributor

@pravinblaze pravinblaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@glopezdiest glopezdiest merged commit ae36a62 into dev Dec 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the glopezdiest/local_planner_offset branch December 7, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants