-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several improvements to OpenSCENARIO support #739
Conversation
d109de0
to
de57882
Compare
de57882
to
32ae1ff
Compare
Added support the following features: - Consideration of traffic lights - Use of brake lights Fixed exception on empty waypoint list.
32ae1ff
to
05561b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @fabianoboril)
Docs/CHANGELOG.md, line 24 at r1 (raw file):
* Extended SimpleVehicleController (OSC) to handle traffic lights * Generalized visualizer attached to OSC controllers
newlines?
srunner/scenariomanager/carla_data_provider.py, line 596 at r1 (raw file):
_spawn_point.location.x = transform.location.x _spawn_point.location.y = transform.location.y if blueprint.has_tag('walker'):
always valid? Maybe at least have some description
srunner/scenariomanager/actorcontrols/carla_autopilot.py, line 38 at r1 (raw file):
super(CarlaAutoPilotControl, self).__init__(actor) self._actor.set_autopilot(enabled=True)
route + target_speed cannot be set, right? Maybe it would help if you override those BasicControl methods and print out that it's not supported.
srunner/scenariomanager/actorcontrols/simple_vehicle_control.py, line 56 at r1 (raw file):
(consider_trafficlights, true/false) - Enable consideration of traffic lights (max_deceleration, float) - Use a reasonable deceleration value for this vehicle
also add max_accel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @fpasch)
Docs/CHANGELOG.md, line 24 at r1 (raw file):
Previously, fpasch (fpasch) wrote…
newlines?
done
srunner/scenariomanager/carla_data_provider.py, line 596 at r1 (raw file):
Previously, fpasch (fpasch) wrote…
always valid? Maybe at least have some description
Done.
srunner/scenariomanager/actorcontrols/carla_autopilot.py, line 38 at r1 (raw file):
Previously, fpasch (fpasch) wrote…
route + target_speed cannot be set, right? Maybe it would help if you override those BasicControl methods and print out that it's not supported.
The base class provides these messages already.
srunner/scenariomanager/actorcontrols/simple_vehicle_control.py, line 56 at r1 (raw file):
Previously, fpasch (fpasch) wrote…
also add max_accel
Done.
Change-Id: If395133f47102adbf88d00c35f814c49c7414eac
05561b4
to
ba2de6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @fabianoboril)
This change is