Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to OpenSCENARIO support #739

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Conversation

fabianoboril
Copy link
Collaborator

@fabianoboril fabianoboril commented Mar 12, 2021

  • Added controller using CARLA's autopilot (in replacement for ActivateControllerAction)
  • Added support for storyboards with multiple stories
  • Extended SimpleVehicleController (OSC) to handle traffic lights, turn on brake lights and use reasonable acceleration/deceleration
  • Improved reloading of OpenDRIVE maps

This change is Reviewable

Copy link
Contributor

@fpasch fpasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @fabianoboril)


Docs/CHANGELOG.md, line 24 at r1 (raw file):

* Extended SimpleVehicleController (OSC) to handle traffic lights
* Generalized visualizer attached to OSC controllers

newlines?


srunner/scenariomanager/carla_data_provider.py, line 596 at r1 (raw file):

                _spawn_point.location.x = transform.location.x
                _spawn_point.location.y = transform.location.y
                if blueprint.has_tag('walker'):

always valid? Maybe at least have some description


srunner/scenariomanager/actorcontrols/carla_autopilot.py, line 38 at r1 (raw file):

        super(CarlaAutoPilotControl, self).__init__(actor)
        self._actor.set_autopilot(enabled=True)

route + target_speed cannot be set, right? Maybe it would help if you override those BasicControl methods and print out that it's not supported.


srunner/scenariomanager/actorcontrols/simple_vehicle_control.py, line 56 at r1 (raw file):

                                        (consider_trafficlights, true/false) - Enable consideration of traffic lights
                                        (max_deceleration, float)            - Use a reasonable deceleration value for
                                                                               this vehicle

also add max_accel

Copy link
Collaborator Author

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @fpasch)


Docs/CHANGELOG.md, line 24 at r1 (raw file):

Previously, fpasch (fpasch) wrote…

newlines?

done


srunner/scenariomanager/carla_data_provider.py, line 596 at r1 (raw file):

Previously, fpasch (fpasch) wrote…

always valid? Maybe at least have some description

Done.


srunner/scenariomanager/actorcontrols/carla_autopilot.py, line 38 at r1 (raw file):

Previously, fpasch (fpasch) wrote…

route + target_speed cannot be set, right? Maybe it would help if you override those BasicControl methods and print out that it's not supported.

The base class provides these messages already.


srunner/scenariomanager/actorcontrols/simple_vehicle_control.py, line 56 at r1 (raw file):

Previously, fpasch (fpasch) wrote…

also add max_accel

Done.

Change-Id: If395133f47102adbf88d00c35f814c49c7414eac
Copy link
Contributor

@fpasch fpasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fabianoboril)

@fabianoboril fabianoboril merged commit b6a6cc0 into master Mar 12, 2021
@fabianoboril fabianoboril deleted the improvementOsc branch March 12, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants