Improved reloading of OpenDRIVE maps in OSC

[fabianoboril]

Before enforcing a reload of the CARLA map when using OpenSCENARIO
the currently loaded map is compared with the new map. This comparison
was reworked to enforce that both maps start with the '' start tag:

• Perform map string comparison only for content after tag
• Load OpenDRIVE map using vertex_distance etc. parameters

Reworked handling of TrafficManager inside ScenarioRunner to improve
startup time:

• Moved TrafficManager code from constructor to _load_and_run_scenario after updating the world

---

This change is 

[glopezdiest]

Reviewed 1 of 2 files at r1, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @fabianoboril and @fpasch)

---

scenario_runner.py, line 321 at r3 (raw file):

CarlaDataProvider.set_client(self.client)

Not really an issue but we can move this to the init, where the client is created

---

scenario_runner.py, line 364 at r3 (raw file):

Quoted 5 lines of code…

        CarlaDataProvider.set_traffic_manager_port(int(self._args.trafficManagerPort))
        tm = self.client.get_trafficmanager(int(self._args.trafficManagerPort))
        tm.set_random_device_seed(int(self._args.trafficManagerSeed))
        if self._args.sync:
            tm.set_synchronous_mode(True)

No comments here. However, I saw that we aren't setting the TM to async on cleanup, which we should do definitely do.

[fabianoboril]

Reviewed 1 of 2 files at r1, 2 of 2 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @fabianoboril and @fpasch)

scenario_runner.py, line 321 at r3 (raw file):

CarlaDataProvider.set_client(self.client)

Not really an issue but we can move this to the init, where the client is created

scenario_runner.py, line 364 at r3 (raw file):

Quoted 5 lines of code…

        CarlaDataProvider.set_traffic_manager_port(int(self._args.trafficManagerPort))
        tm = self.client.get_trafficmanager(int(self._args.trafficManagerPort))
        tm.set_random_device_seed(int(self._args.trafficManagerSeed))
        if self._args.sync:
            tm.set_synchronous_mode(True)

No comments here. However, I saw that we aren't setting the TM to async on cleanup, which we should do definitely do.

Done.

[glopezdiest]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @fpasch)