Stop assuming signed chars in DUMP_STRING(); that results in inconsis…

…tent output in platforms like ARM64 #34
carlosabalde · May 29, 2024 · 70e8448 · 70e8448
1 parent 118b94e
commit 70e8448
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -19,6 +19,7 @@ name: libvmod-cfg-master
 services:
   dev:
     hostname: dev
+    # platform: linux/arm64/v8
     build:
       context: .
       no_cache: true

diff --git a/src/variables.c b/src/variables.c
@@ -129,7 +129,7 @@ static const char *json_hex_chars = "0123456789abcdef";
     do { \
         DUMP_CHAR('"'); \
         for (int i = 0; value[i]; i++) { \
-            if (value[i] > 31 && value[i] != '\"' && value[i] != '\\') { \
+            if (value[i] > 31 && value[i] < 127 && value[i] != '\"' && value[i] != '\\') { \
                 DUMP_CHAR(value[i]); \
             } else { \
                 DUMP_CHAR('\\'); \