Abort 'vcl_init' asap if a VMOD object instance cannot be created. See …

…https://varnish-cache.org/lists/pipermail/varnish-dev/2024-September/009853.html
carlosabalde · Sep 17, 2024 · d1c7714 · d1c7714
1 parent 04052dd
commit d1c7714
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/core.h b/src/core.h
@@ -413,6 +413,9 @@ extern vmod_state_t vmod_state;
 #define REDIS_FAIL_WS(ctx, result) \
     REDIS_FAIL(ctx, result, "Workspace overflow")
 
+#define REDIS_FAIL_INSTANCE(ctx, result) \
+    REDIS_FAIL(ctx, result, "Failed to create instance")
+
 #ifdef TLS_ENABLED
 #define REDIS_TLS(ctx, rcontext, db, message1, message2, ...) \
     do { \

diff --git a/src/vmod_redis.c b/src/vmod_redis.c
@@ -580,6 +580,10 @@ vmod_db__init(
             "New database instance registered (db=%s)",
             instance->name);
     }
+
+    if (*db == NULL) {
+        REDIS_FAIL_WS(ctx,);
+    }
 }
 
 VCL_VOID