Fix parent interfaces not recognized as extended

carlosas · Nov 23, 2024 · 55154db · 55154db
1 parent 3af2ffb
commit 55154db
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 3 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,7 +1,10 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
-## 0.10.11
+## 0.10.20
+* Fix parent interfaces not recognized as extended.
+
+## 0.10.19
 * Add `IsTrait`  and `IsNotTrait` selectors.
 * Add `IsException`, `IsError`, and `IsThrowable` selectors.
 

diff --git a/src/Rule/Extractor/Relation/AllParentsExtractor.php b/src/Rule/Extractor/Relation/AllParentsExtractor.php
@@ -20,9 +20,17 @@ public function getNodeType(): string
      */
     protected function extractNodeClassNames(Node $node, Scope $scope): array
     {
+        $classReflection = $node->getClassReflection();
+        if ($node->getClassReflection()->isInterface()) {
+            return array_map(
+                static fn (ClassReflection $c) => $c->getName(),
+                $classReflection->getInterfaces()
+            );
+        }
+
         return array_map(
             static fn (ClassReflection $c) => $c->getName(),
-            $node->getClassReflection()->getParents()
+            $classReflection->getParents()
         );
     }
 }
diff --git a/src/Rule/Extractor/Relation/ParentExtractor.php b/src/Rule/Extractor/Relation/ParentExtractor.php
@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InClassNode;
+use PHPStan\Reflection\ClassReflection;
 
 trait ParentExtractor
 {
@@ -19,7 +20,16 @@ public function getNodeType(): string
      */
     protected function extractNodeClassNames(Node $node, Scope $scope): array
     {
-        $parent = $node->getClassReflection()->getParentClass();
+        $classReflection = $node->getClassReflection();
+
+        if ($node->getClassReflection()->isInterface()) {
+            return array_map(
+                static fn (ClassReflection $c) => $c->getName(),
+                $classReflection->getImmediateInterfaces()
+            );
+        }
+
+        $parent = $classReflection->getParentClass();
 
         return $parent === null ? [] : [$parent->getName()];
     }