-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix namespace matching #254
Conversation
Hi. Thanks for the PR. I'll have a look to the failing PHPCS-Fixer ASAP, it doesnt seem an error from the changes, probably related to an update |
I added a test, but I don't know if this is the proper way to do this. There don't seem to be existing tests specifically targeting selectors. However, I verified that it gives an error with the old code, and a success after the modification, as it should. |
it seems to work 👍 that test is enough, I will try to improve the system in the future. however, there are two failing steps in the CI:
|
It looks all OK now |
This fixes the bug where, for example, the namespace
App\DomainService
incorrectly gets matched usingApp\Domain
Resolves #253