Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conditionals to detect OS and change paths accordingly #32

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Added conditionals to detect OS and change paths accordingly #32

merged 1 commit into from
Jan 16, 2023

Conversation

ruia
Copy link
Collaborator

@ruia ruia commented Jan 14, 2023

@carloscastrojumo pls test on MacOS and give feedback 😄

On my end tested on Windows and Ubuntu@WSL working fine 👌

@ruia ruia requested a review from carloscastrojumo January 14, 2023 00:19
@ruia ruia self-assigned this Jan 14, 2023
@ruia ruia linked an issue Jan 14, 2023 that may be closed by this pull request
Makefile not working on Windows / Linux #31
Closed
carloscastrojumo
carloscastrojumo approved these changes Jan 15, 2023
View reviewed changes
Copy link
Owner

@carloscastrojumo carloscastrojumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@ruia ruia merged commit 3b94c9a into main Jan 16, 2023
@ruia ruia deleted the 31-makefile-not-working-on-windows-linux branch January 16, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloscastrojumo carloscastrojumo carloscastrojumo approved these changes

Assignees

@ruia ruia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile not working on Windows / Linux
2 participants
@ruia @carloscastrojumo