Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

36 create command ls tags list tags available #37

Merged
merged 4 commits into from
Feb 22, 2023
Merged

36 create command ls tags list tags available #37

merged 4 commits into from
Feb 22, 2023
+90 −8

Conversation

ruia
Copy link
Collaborator

@ruia ruia commented Feb 11, 2023

Is there a cleaner way to do the implementation on Mongo GetTags, specifically the cast from interface to slice.

Used the old way maybe change to mongo way of query?

ruia added 4 commits February 11, 2023 18:46
@ruia
Code cleanup

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
a0ff77e
@ruia
Implemented function to print tags list

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9de46ab
@ruia
Implemented GetTags to obtain available tags

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8ce9292
@ruia
Added comas to make tags more readable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3620390
@ruia ruia linked an issue Feb 11, 2023 that may be closed by this pull request
Create command ls tags - List tags available #36
Closed
carloscastrojumo
carloscastrojumo approved these changes Feb 22, 2023
View reviewed changes
Copy link
Owner

@carloscastrojumo carloscastrojumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cast to convert the interface is expected

@ruia ruia merged commit 2d7d2e0 into main Feb 22, 2023
@ruia ruia deleted the 36-create-command-ls-tags-list-tags-available branch February 22, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carloscastrojumo carloscastrojumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create command ls tags - List tags available
2 participants
@ruia @carloscastrojumo