Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Migrate to app directory #1164

Merged
merged 20 commits into from
Apr 28, 2023
Merged

🚚 Migrate to app directory #1164

merged 20 commits into from
Apr 28, 2023

Conversation

carloscuesta
Copy link
Owner

@carloscuesta carloscuesta commented Apr 14, 2023

Description

Migrating the website codebase to app directory.

Unresolved issues

Demo

See deploy preview.

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carloscuesta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 11:21am

@carloscuesta carloscuesta force-pushed the migrate-to-app-directory branch 2 times, most recently from bb99354 to ac61ad9 Compare April 17, 2023 21:41
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 65.21% and project coverage change: -7.41 ⚠️

Comparison is base (e19d999) 93.49% compared to head (e28c996) 86.09%.

❗ Current head e28c996 differs from pull request most recent head f45ab8d. Consider uploading reports for the commit f45ab8d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
- Coverage   93.49%   86.09%   -7.41%     
==========================================
  Files          64       51      -13     
  Lines         415      302     -113     
  Branches       45       43       -2     
==========================================
- Hits          388      260     -128     
- Misses         24       39      +15     
  Partials        3        3              
Impacted Files Coverage Δ
...ut/components/Experience/Job/CompanyLogo/index.tsx 100.00% <ø> (ø)
...bout/components/Experience/Job/Timestamp/index.tsx 100.00% <ø> (ø)
src/app/about/components/Experience/Job/index.tsx 100.00% <ø> (ø)
src/app/about/components/Online/index.tsx 0.00% <0.00%> (ø)
...rc/app/about/components/Travelling/Label/index.tsx 0.00% <ø> (ø)
src/app/about/components/Travelling/Map/index.tsx 0.00% <ø> (ø)
src/app/about/components/Travelling/index.tsx 0.00% <0.00%> (ø)
src/app/about/components/WhoAmI/index.tsx 100.00% <ø> (ø)
...pp/blog/[slug]/components/DisqusComments/index.tsx 100.00% <ø> (ø)
...app/blog/[slug]/components/FeaturedImage/index.tsx 100.00% <ø> (ø)
... and 32 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carloscuesta carloscuesta merged commit bc53227 into master Apr 28, 2023
@carloscuesta carloscuesta deleted the migrate-to-app-directory branch April 28, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant