Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmder colors #26

Merged
merged 5 commits into from
Nov 28, 2017
Merged

cmder colors #26

merged 5 commits into from
Nov 28, 2017

Conversation

kolmogorov42
Copy link
Contributor

@kolmogorov42 kolmogorov42 commented Nov 19, 2017

Back with a new pull request and screenshots.

This time, I recreated the theme colors based on the image in the README page, since color codes seemed to be inconsistent across files. I took advantage of the ConEmu feature that allows users to pick one of 16 base colors as default text color, and another as default BG color.

I had to change one small option in your file, as to prevent cmder from starting in Powershell mode by default, which caused an error message and is probably not what the user wants.

In addition, I modified your LS_COLORS a bit as a way to prevent directories and other kinds of items from being shown on a "black" background, which is not the same as the default BG color I picked, following your design. So I just stripped all the "40" codes I could find, though this might not be ideal (you might want specific kinds of items to really be displayed on black, rather than the terminal's bg color).

There's a whole bunch of other things I'd like to discuss about LS_COLORS, but that might be the subject of another PR.

Screens before PR

conemu64_2017-11-19_15-32-43
conemu64_2017-11-19_15-37-32

After PR

conemu64_2017-11-19_16-01-24
conemu64_2017-11-19_16-06-34

Screens show the Dark theme, but my xml file allows the user to pick either.

Screens have been taken from a fresh cmder-mini install, showing Linux from a Vagrant install equipped with oh-my-zsh and materialshell.zsh.

@carloscuesta
Copy link
Owner

Going to review it! @kolmogorov42

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Thanks 🎉

@carloscuesta carloscuesta merged commit c620cd6 into carloscuesta:master Nov 28, 2017
@kolmogorov42
Copy link
Contributor Author

Cheers! 🍻
As for LS_COLORS, do change it back if you think I've been messing too much with the backgrounds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants