✨ Adding support for windows terminal #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumped "selectionBackground" slightly up because it was not visible. text color has been assigned to "foreground"
Windows powershell uses brightblack as command line switches for commands.
The link on the main Readme.md will navigate to the windows terminal heading correctly.
| @@ -0,0 +1,23 @@ | |||
| { | |||
There was a problem hiding this comment.
Hey! Since the folder is already named windows I think we should rename windowsterminal to terminal ?
Wdyt 🤔
There was a problem hiding this comment.
I think that's a good catch, thank you!
renaming windowsterminal to terminal because the folder one level up is also named "windows". path windows/terminal is better then windows/windowsterminal.
carloscuesta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I saw there is no support for Windows Terminal. Hence I traced back my own steps and I am submitting a pull request!
Here are some things to consider,
#9cb0b9Thank you!