-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for linux-arm64 platform #48
Conversation
Thanks for the PR @leoli0605! |
a135624
to
dd5e454
Compare
Hi @carlosperate, sorry for the late reply. I've updated the function that determines whether a Linux architecture is x86_64 or arm64. Fixed the incorrect MD5 checksum and download URL for arm64, and added some conditions to test.yml to ensure every test will pass when the architecture is arm64. Here's the test workflow within Linux arm64 architecture; please check it. If there are any questions, please let me know. Thank you. BTW, for this PR, I did not update the |
Hi @carlosperate, could you please take the time to review this PR when you have a moment? Thank you. |
Sorry it's taken me this long to review this PR, I've been meaning to set up a Raspberry Pi to be able to test this regularly in CI, but didn't really get around to it until now. I've run an initial test and it looks like this is picking up the Unfurtunately I cannot check the log from you CI run as it's been too long, do you remember checking which gcc version it was downloading? If you could push an empty commit to trigger another CI run on your fork it'd be useful to be able to compare the logs. |
Ah, sorry I forgot you mentioned this and I didn't rebuild/package:
It seems to be working now, but will take a little while for all the jobs to run through the single Pi for linux arm64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR adding Linux arm64 support, it's really appreciated!
No description provided.