Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Use JORAM data to retrieve gas prices #48

Merged
merged 7 commits into from
Oct 22, 2023

Conversation

carlosrsabreu
Copy link
Owner

Related issues

Closes #47

What does this PR do?

Clearly state the reason for this change. What problem is it solving or feature is it adding?

Starts using JORAM gas prices and drop DRET gas prices, due to the reasons mentioned in the issue.

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub compliant mermaid graphs to visually represent the solution.

  • Prices are now retrieved from the JORAM PDF;
  • Extracted functions that should be global to a file called functions.py;

Implementation Details

Explain the details of the implementation and the reasoning behind it. Where should the reviewer start?

  • Reviewer should start in the file update_gas_prices.py.

@carlosrsabreu carlosrsabreu changed the base branch from main to develop October 14, 2023 18:23
@HarryVasanth HarryVasanth added the 🪄 enhancement New feature or enhancement label Oct 15, 2023
@HarryVasanth HarryVasanth changed the title chore: use joram data to retrieve gas prices [FEATURE]: Use JORAM data to retrieve gas prices Oct 15, 2023
Copy link
Collaborator

@HarryVasanth HarryVasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

joram.py Show resolved Hide resolved
history/gas_info_history.json Outdated Show resolved Hide resolved
update_gas_prices.py Show resolved Hide resolved
Copy link
Collaborator

@Dntfreitas Dntfreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

functions.py Outdated Show resolved Hide resolved
joram.py Outdated Show resolved Hide resolved
update_gas_prices.py Show resolved Hide resolved
@carlosrsabreu
Copy link
Owner Author

Made some last changes on the code, please @Dntfreitas or @HarryVasanth check and merge 👯

@Dntfreitas
Copy link
Collaborator

LGTM :)

@HarryVasanth HarryVasanth merged commit 7736328 into develop Oct 22, 2023
@HarryVasanth HarryVasanth deleted the chore/use-joram-data branch October 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement New feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Use JORAM gas prices
3 participants