-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new htmlextra output #57
Added new htmlextra output #57
Conversation
@Scott-Emberson this is awesome! I love seeing more support, especially because my job has gotten so hectic. I’ll look this over when I get a chance and I’m sure @sebcaps will as well. Two things I see just glancing over on my iPad is that you might be requiring the path on the new field (which I’m thinking we’ll likely not want to do) and the task.json looks like it probably got auto formatted which makes it difficult to tell what actually changed. |
Sounds good to me with the following remarks:
Good job anyway 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed
Sorry do I need to do anything more on this pull request (it's my first one) |
@Scott-Emberson, before merging the PR can you just have a look to my comment about |
Thanks for including the Not sure if this is useful or relevant in this context but I've turned off the |
Just getting back to this. The main issue I'm having in the compare is the tabs vs spaces change in the task.json file. I'll look through this and try to find the differences. |
Turns out to be easier than I expected. Looks good. @sebcaps any reason you can think of why this wouldn't be backward compatible? |
@sebcaps I have attempted to add the commands for the htmlextra options. #56