Added suppress function to temporary prevent the fire function. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bounce is suppress untill suppress(false) is called.
| @@ -82,7 +82,7 @@ function ouibounce(el, custom_config) { | |||
| // You can use ouibounce without passing an element | |||
| // https://github.com/carlsednaoui/ouibounce/issues/30 | |||
| function fire() { | |||
| if (isDisabled()) { return; } | |||
| if (isDisabled() || supressed) { return; } | |||
There was a problem hiding this comment.
IMO, supressed should be a part of the isDisabled function. It's easier to read that way.
function isDisabled() {
return supressed || (checkCookieValue(cookieName, 'true') && !aggressive);
}
| @@ -123,11 +123,18 @@ function ouibounce(el, custom_config) { | |||
| _html.removeEventListener('keydown', handleKeydown); | |||
| } | |||
|
|
|||
| var supressed; | |||
There was a problem hiding this comment.
This should probably be up with the other variables near the top and initialized to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added suppress function. The fire function won't be executed when ouibounce is suppressed untill suppress(false) is called.
In my case I did not want to fire function to trigger when another dialog was open on my page. However, I wanted the fire function to be triggered again once that dialog is closed.
Calling suppress(true) when opening the dialog and suppres(false) when closing this dialog does the trick now.