Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choices to contains optgroups in DateRangeFilter #1621

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

fle
Copy link
Contributor

@fle fle commented Nov 7, 2023

This PR addresses #1620 and implements the suggested solution.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Merging #1621 (c4171b0) into main (4a618e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c4171b0 differs from pull request most recent head 63a93ff. Consider uploading reports for the commit 63a93ff to get more accurate results

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          15       15           
  Lines        1281     1283    +2     
=======================================
+ Hits         1263     1265    +2     
  Misses         18       18           
Files Coverage Δ
django_filters/filters.py 100.00% <100.00%> (ø)

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great. Thanks

@carltongibson carltongibson merged commit d693a59 into carltongibson:main Nov 29, 2023
8 checks passed
last-partizan pushed a commit to last-partizan/django-filter that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants