Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When value is a list it should be returned as is (subsum PR 1340) #1637

Merged
merged 4 commits into from
Jan 27, 2024

Conversation

bryan-brancotte
Copy link
Contributor

@bryan-brancotte bryan-brancotte commented Jan 26, 2024

Adding tests on #1340

Closes #1103

@bryan-brancotte bryan-brancotte marked this pull request as draft January 26, 2024 09:27
@bryan-brancotte bryan-brancotte marked this pull request as ready for review January 26, 2024 09:29
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for picking this up @bryan-brancotte 💝

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd662c8) 98.59% compared to head (a8ff978) 98.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          15       15           
  Lines        1283     1285    +2     
=======================================
+ Hits         1265     1267    +2     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carltongibson carltongibson merged commit a2f7aba into carltongibson:main Jan 27, 2024
9 checks passed
@bryan-brancotte bryan-brancotte deleted the patch-2 branch January 29, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.1.0] BaseCSVWidget.value_from_datadict — AttributeError: 'list' object has no attribute 'split'
4 participants