Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove usage of deprecated is_iterable util #1642

Merged

Conversation

adamantike
Copy link
Contributor

Django announced [1] that the django.utils.itercompat module is deprecated since Django 5.1.

Instead, the same behavior can be achieved with an instance comparison against Iterable [2].

[1] https://docs.djangoproject.com/en/dev/releases/5.1/#features-deprecated-in-5-1
[2] https://docs.python.org/3/library/collections.abc.html#collections.abc.Iterable

Django announced [1] that the `django.utils.itercompat` module is
deprecated since Django 5.1.

Instead, the same behavior can be achieved with an instance comparison
against `Iterable` [2].

[1] https://docs.djangoproject.com/en/dev/releases/5.1/#features-deprecated-in-5-1
[2] https://docs.python.org/3/library/collections.abc.html#collections.abc.Iterable
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good.

@carltongibson carltongibson merged commit d0e34ef into carltongibson:main Mar 8, 2024
9 checks passed
@adamantike adamantike deleted the fix/remove-is_iterable-usage branch March 8, 2024 16:03
last-partizan pushed a commit to last-partizan/django-filter that referenced this pull request Sep 12, 2024
Django announced [1] that the `django.utils.itercompat` module is
deprecated since Django 5.1.

Instead, the same behavior can be achieved with an instance comparison
against `Iterable` [2].

[1] https://docs.djangoproject.com/en/dev/releases/5.1/#features-deprecated-in-5-1
[2] https://docs.python.org/3/library/collections.abc.html#collections.abc.Iterable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants