remove ... in rest_framework.txt to make life easy
#1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone silly like me, who just copies and posts the code snippet with the ..., will get an exception `AttributeError: 'ellipsis' object has no attribute 'rsplit'`. So let's just remove it and make life easy.
|
IMO it's very important to retain some indicator that the example does not represent the complete configuration, to avoid confusion. |
So let's add a comment and keep the ellipsis there.
Done. I just a comment. |
carltongibson
approved these changes
Mar 26, 2024
Coverage report
This PR does not seem to contain any modification to coverable code. |
last-partizan
pushed a commit
to last-partizan/django-filter
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone silly like me, who just copies and posts the code snippet with the ..., will get an exception
AttributeError: 'ellipsis' object has no attribute 'rsplit'. So let's just remove it and make life easy.