Fix grouped choices as dict #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
approved these changes
Jul 11, 2024
|
Oh, except the tests didn't like it... |
|
@saevarom I'm looking towards a release. Do you have time to address the failing test on Django 4.2? |
|
I'll take a look now |
|
@carltongibson I've pushed a fix, could you approve the test run? |
|
@saevarom great thanks. The isort run is playing up. I can look at that later on. Other than that 👍 |
|
|
Great. Thanks 🎁 |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
@saevarom If we want perfect coverage here we'd also need to check the assert is raised for Django 4.2... |
|
This is now available in v24.3 on PyPI. Thanks @saevarom! |
last-partizan
pushed a commit
to last-partizan/django-filter
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt to fix #1667
I decided to go for a simple approach in normalizing the choices, and used a utility function from django 5.0. I think that's OK since this method of defining choices was first introduced in django 5.0.