-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unknown_field_behavior feature #1675
Add unknown_field_behavior feature #1675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Next steps would be to add the option to the Filterset reference doc.
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking nice and tight. 👍
Just added a change to the docs. Not sure if the following line is redundant due to the explanation for each enum value:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks great. Let's have it! Welcome aboard! ⛵️
I will look towards a release.
This is now available in v24.3 on PyPI. Thanks @loeeess! |
That's great to see @carltongibson , thanks so much! 🎉 What's the best way to proceed, should I close the issue? |
Oops. I didn't see that. Closed it now. Thanks. |
Based on the suggestion mentioned in #1666, I have added the
handle_unrecognized_field
method to theBaseFilterSet
and a new optionunknown_field_behavior
inFilterSetOptions
where users can specify how unrecognized field types should be handled (raise - default, warn, ignore).Changes include:
handle_unrecognized_field
method inBaseFilterSet
, including newFilterSet
optionraise
,warn
,ignore
, andinvalid
behaviors