Cast data to QueryDict in LinkWidget.render_option #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajowu
force-pushed
the
pajowu/querydict
branch
from
9c57e7d to
d626a08
Compare
pajowu
force-pushed
the
pajowu/querydict
branch
2 times, most recently
from
7cd4ce6 to
d586ed9
Compare
carltongibson
force-pushed
the
pajowu/querydict
branch
from
d586ed9 to
2644a33
Compare
|
Hi @pajowu Sorry for the slow follow up. 🤹 I've pushed a change showing what I had in mind. Can you take a look and let me know what you think? |
carltongibson
force-pushed
the
pajowu/querydict
branch
from
2644a33 to
67af91c
Compare
carltongibson
force-pushed
the
pajowu/querydict
branch
from
67af91c to
fc0674f
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1689