Move filter options to Meta class

[rpkilby]

Extracted the strict, filter_overrides, and order_by_field moves to Meta from the other PRs. This resolves #430.

[rpkilby]

@carltongibson - btw, this is also ready for review.

[rpkilby]

Sweet. I will rebase the other PRs later tonight*

*probably

[carltongibson]

@rpkilby No stress. It's just #429 that I really want to get in. Then I'll push 0.15 and we can start burning the deprecations. 🔥

Thanks for all the input!

[blueyed]

This causes an error with rest_framework_gis, which tries to update the filter_overrides: https://github.com/djangonauts/django-rest-framework-gis/blob/7ec925a97a1eae45f57733a49ddde7ddec119458/rest_framework_gis/filters.py#L87

I've only skimmed this, but it looks like handling this was not taken from #429?
Is it planned to be done there, or was it lost?

[carltongibson]

Well #429 is incoming, but the update will need to change location it looks like.

Exactly what are you referring to by "this" and "it" in "handling this" and "Is it planned"? (again I'm not quite following you immediately)

[blueyed]

Sorry, I've meant to ask if it would work after #429, but only issue a deprecation warning (according to https://github.com/carltongibson/django-filter/pull/429/files#diff-c82ea95d2a317d98860bf154f27d3e17R181). And since this could have been done in this PR (#459) already, I've thought that it might have slipped through.

but the update will need to change location it looks like.

But it should not throw an error, but only warn about the deprecation, right?

[carltongibson]

But it should not throw an error, but only warn about the deprecation, right?

It's reference semantics, so it should be fine yes. I think :-)

[rpkilby]

This will only work if filter_overrides is defined on the actual subclass. eg,

class MyFilterSet(GeoFilterSet):
    filter_overrides = {}
    ...

If you omit the attribute, there is no filter_overrides dict to update as it's been moved to Meta, thus an AttributeError

Also, the correct thing for rest_framework_gis to do after #429 merges is to copy & update the class FILTER_DEFAULTS.

[blueyed]

Thanks for your clarification, @rpkilby.
I guess the next release should be versioned 1.0 then instead? (because of this API breaking change).

[carltongibson]

The breakage is covered by the 0.x already. I want to make the 1.0 after removing all the deprecations.