Fix OrderingFilter label translation #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ad-m! |
ad-m
reviewed
Nov 4, 2016
| @@ -656,7 +656,7 @@ def normalize_fields(cls, fields): | |||
|
|
|||
| def build_choices(self, fields, labels): | |||
| ascending = [ | |||
| (param, labels.get(field, pretty_name(param))) | |||
| (param, labels.get(field, _(pretty_name(param)))) | |||
| for field, param in fields.items() | |||
| ] | |||
| descending = [ | |||
There was a problem hiding this comment.
Use:
descending = [
('-%s' % pair[0], labels.get('-%s' % pair[0], self.descending_fmt % pair[1]))
for pair in ascending
]
to support translation of label for descending options (eg, '-username'). There is no reason to not support them. In some cases it can improve UX experience by naming orders in more natural ways.
There was a problem hiding this comment.
That's not a bad point. It's also a fairly trivial thing to add. Currently updating the PR to include this & your corresponding test.
There was a problem hiding this comment.
@ad-m - see the latest commit.
rpkilby
force-pushed
the
fix-orderingfilter-translation
branch
from
bca402d to
6955fd2
Compare
rpkilby
force-pushed
the
fix-orderingfilter-translation
branch
from
6955fd2 to
b63d222
Compare
|
LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes and resolves #543.
This also adds descending options to
OrderingFilter.field_labels.