Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for verbose_field_name #722

Merged
merged 2 commits into from
May 19, 2017
Merged

Fix for verbose_field_name #722

merged 2 commits into from
May 19, 2017

Conversation

carltongibson
Copy link
Owner

Closes #716

@carltongibson
Copy link
Owner Author

39e4872 adds a failing test #716..

I don't quite understand it as it stands. The first two cases pass. It's the last one that raises the error, but it doesn't make much sense to me.

@carltongibson carltongibson changed the title Fix for verbose_name Fix for verbose_field_name May 18, 2017
@carltongibson carltongibson mentioned this pull request May 18, 2017
Closed
@codecov-io
Copy link

codecov-io commented May 18, 2017 •
edited
Loading

Codecov Report

Merging #722 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #722      +/-   ##
===========================================
+ Coverage    98.13%   98.13%   +<.01%     
===========================================
  Files           15       15              
  Lines         1123     1125       +2     
===========================================
+ Hits          1102     1104       +2     
  Misses          21       21
Impacted Files Coverage Δ
django_filters/utils.py 98.21% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876d79f...2217618. Read the comment docs.

@carltongibson carltongibson added this to the Version 1.0.4 milestone May 19, 2017
@carltongibson carltongibson merged commit 9564293 into develop May 19, 2017
@carltongibson carltongibson deleted the bugfix/716-verbose_name branch May 19, 2017 06:38
@carltongibson carltongibson mentioned this pull request May 19, 2017
Merged
carltongibson pushed a commit that referenced this pull request May 19, 2017
Version 1.0.4 (#723)
7e94907 
* Update CHANGES

* Adjust README

* Fixed year in CHANGES (#721)

* Fix for verbose_field_name (#722)

* Failing test for #716

* Handle case where related_name is None

* Update version and changes for 1.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Version 1.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@carltongibson @codecov-io