Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update {Range,LookupType}Widgets to use suffixes #770

Merged

Conversation

rpkilby
Copy link
Collaborator

@rpkilby rpkilby commented Aug 31, 2017

Breaking changes from #681 that were meant for a 1.2 or 2.0 release.

@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #770 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #770      +/-   ##
===========================================
+ Coverage    97.42%   97.43%   +0.01%     
===========================================
  Files           15       15              
  Lines         1202     1210       +8     
===========================================
+ Hits          1171     1179       +8     
  Misses          31       31
Impacted Files Coverage Δ
django_filters/fields.py 100% <100%> (ø) ⬆️
django_filters/widgets.py 98.75% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4530a...ce78c54. Read the comment docs.

@rpkilby rpkilby force-pushed the suffixed-multiwidget-default branch from 1f2f13d to ce78c54 Compare October 20, 2017 17:28
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This just needs a rebase, and a comment in the migration doc, just saying that the default behaviour changed, if you would. 😊

@rpkilby rpkilby force-pushed the suffixed-multiwidget-default branch from ce78c54 to bf0a6c9 Compare October 24, 2017 07:47
@carltongibson carltongibson merged commit 37ba316 into carltongibson:develop Oct 24, 2017
@rpkilby rpkilby deleted the suffixed-multiwidget-default branch October 24, 2017 07:48
carltongibson pushed a commit that referenced this pull request Oct 24, 2017
* Update {Range,LookupType}Widgets to use suffixes

* Add SuffixedMultiWidget migration note
carltongibson pushed a commit that referenced this pull request Oct 24, 2017
* Update {Range,LookupType}Widgets to use suffixes

* Add SuffixedMultiWidget migration note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants