Improve IsoDateTimeField test clarity #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use appropriate asserts for isinstance and is None - Replace confusing tz offset calculations with simpler time deltas.
Codecov Report
@@ Coverage Diff @@
## develop #790 +/- ##
========================================
Coverage 97.45% 97.45%
========================================
Files 15 15
Lines 1220 1220
========================================
Hits 1189 1189
Misses 31 31Continue to review full report at Codecov.
|
|
Good timing. I was just about to roll 1.1 |
carltongibson
approved these changes
Oct 18, 2017
|
Side note - I'm amused that my 100th pr for django-filter is improving my first pr 😛 . |
carltongibson
pushed a commit
that referenced
this pull request
Oct 19, 2017
- Use appropriate asserts for isinstance and is None - Replace confusing tz offset calculations with simpler time deltas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can go into more detail if necessary, but the gist is that I made some weird decisions when writing the tests for #296. This became apparent when reviewing the tests in #750.
This PR removes the tz offset arithmetic, making the tests a little more straightforward to understand.