Method signature improvements #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
changed the title
rpkilby
force-pushed
the
improve-method-sig
branch
from
56ae7f7
to
ffec373
Compare
|
Give me a sec to resolve the conflicts |
rpkilby
force-pushed
the
improve-method-sig
branch
from
ffec373
to
f0d5159
Compare
Codecov Report
@@ Coverage Diff @@
## develop #800 +/- ##
========================================
Coverage 97.71% 97.71%
========================================
Files 15 15
Lines 1138 1138
========================================
Hits 1112 1112
Misses 26 26
Continue to review full report at Codecov.
|
carltongibson
pushed a commit
that referenced
this pull request
Oct 24, 2017
* Improve argument names in FilterSet methods * Reorder Filter args to be keyword-only * Reorder FilterSet kwargs
carltongibson
pushed a commit
that referenced
this pull request
Oct 24, 2017
* Improve argument names in FilterSet methods * Reorder Filter args to be keyword-only * Reorder FilterSet kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f=>fieldin FilterSet classmethodsFilter.__init__args to be mostly keyword-only (depends on going py3-only).