List Django as a dependency in setup.py #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django is a hard dependency of django-filter, it should be listed in install_requires to reflect that.
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 15 15
Lines 1122 1122
=======================================
Hits 1099 1099
Misses 23 23Continue to review full report at Codecov.
|
carltongibson
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django is a hard dependency of django-filter, it should be listed in
install_requiresto reflect that.